Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add adkit to .cspell.json #732

Closed
wants to merge 1 commit into from
Closed

fix: add adkit to .cspell.json #732

wants to merge 1 commit into from

Conversation

@youtalk youtalk self-assigned this May 15, 2024
@HansRobo
Copy link
Member

I can't seem to find the use of "adkit" alone to mean "open-ad-kit" anywhere other than the place you pointed out.
Considering the frequency of the word "adkit", it is appropriate to treat it as a spelling variation that should be avoided rather than added to the dictionary.
The spell check also plays a role in suppressing unwarranted spelling variation, so I am cautious about adding it.

@youtalk
Copy link
Member Author

youtalk commented May 15, 2024

This is not my opinion. It's originally from the current source code. Some AWF committer is using it.

@HansRobo
Copy link
Member

Yeah I got it.

@oguzkaganozt
From what I've searched, you seem to be the only user of "adkit" which means "Open AD Kit".
Is it okay to register "adkit" to the dictionary for spell check and accept it as a valid spelling variation of "Open AD Kit"?
(You are a key figure in Open AD Kit, so if you say yes I'll follow suit)

@oguzkaganozt
Copy link

I think the correct spelling should be the "openadkit" or "openadk" because both on the social media and in technical documentation there are always "open" keyword before "adkit". So I think rather than adding "adkit" as a valid spelling I am proposing to change below lines that are using "adkit" with "openadk":

https://github.com/autowarefoundation/autoware/blob/a79ef50498a6a301446f66e55e834fbc58e78362/.github/workflows/docker-build-and-push-main-self-hosted.yaml#L12

https://github.com/autowarefoundation/autoware/blob/a79ef50498a6a301446f66e55e834fbc58e78362/.github/workflows/docker-build-and-push-main.yaml#L12

@youtalk
Copy link
Member Author

youtalk commented May 29, 2024

We no longer use adkit.
autowarefoundation/autoware#4785

@youtalk youtalk closed this May 29, 2024
@youtalk youtalk deleted the youtalk-patch-2 branch May 29, 2024 02:03
@youtalk youtalk removed their assignment Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants