Merge pull request #188 from tienvx/optimize-imports-and-clean-up-code

Optimize imports and clean up code
tienvx · Mar 19, 2019 · 9fce0ce · 9fce0ce
2 parents 0ebdb19 + 4038fa5
commit 9fce0ce
Show file tree

Hide file tree

Showing 25 changed files with 16 additions and 107 deletions.
diff --git a/src/Command/CreateBugCommand.php b/src/Command/CreateBugCommand.php
@@ -2,8 +2,8 @@
 
 namespace Tienvx\Bundle\MbtBundle\Command;
 
-use Exception;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;

diff --git a/src/Command/GeneratePathCommand.php b/src/Command/GeneratePathCommand.php
@@ -8,8 +8,8 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Workflow\Registry;
-use Tienvx\Bundle\MbtBundle\Graph\Path;
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorManager;
+use Tienvx\Bundle\MbtBundle\Graph\Path;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
 
 class GeneratePathCommand extends AbstractCommand

diff --git a/src/Command/GraphDumpCommand.php b/src/Command/GraphDumpCommand.php
@@ -10,8 +10,8 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Workflow\Workflow;
-use Tienvx\Bundle\MbtBundle\Graph\Dumper\PlantUmlDumper;
 use Tienvx\Bundle\MbtBundle\Graph\Dumper\GraphvizDumper;
+use Tienvx\Bundle\MbtBundle\Graph\Dumper\PlantUmlDumper;
 use Tienvx\Bundle\MbtBundle\Helper\VertexHelper;
 use Tienvx\Bundle\MbtBundle\Service\GraphBuilder;
 

diff --git a/src/Command/ReduceBugCommand.php b/src/Command/ReduceBugCommand.php
@@ -2,14 +2,13 @@
 
 namespace Tienvx\Bundle\MbtBundle\Command;
 
-use Exception;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Messenger\MessageBusInterface;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
-use Tienvx\Bundle\MbtBundle\Message\UpdateBugStatusMessage;
 use Tienvx\Bundle\MbtBundle\PathReducer\PathReducerManager;
 
 class ReduceBugCommand extends AbstractCommand

diff --git a/src/Command/ReducePathCommand.php b/src/Command/ReducePathCommand.php
@@ -6,7 +6,6 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Tienvx\Bundle\MbtBundle\Message\ReducePathMessage;
 use Tienvx\Bundle\MbtBundle\PathReducer\PathReducerManager;
 
 class ReducePathCommand extends AbstractCommand

diff --git a/src/Command/RemoveScreenshotsCommand.php b/src/Command/RemoveScreenshotsCommand.php
@@ -2,14 +2,13 @@
 
 namespace Tienvx\Bundle\MbtBundle\Command;
 
-use Exception;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
-use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
 
 class RemoveScreenshotsCommand extends Command

diff --git a/src/Command/ReportBugCommand.php b/src/Command/ReportBugCommand.php
@@ -2,8 +2,8 @@
 
 namespace Tienvx\Bundle\MbtBundle\Command;
 
-use Exception;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;

diff --git a/src/DependencyInjection/Compiler/GeneratorPass.php b/src/DependencyInjection/Compiler/GeneratorPass.php
@@ -3,8 +3,8 @@
 namespace Tienvx\Bundle\MbtBundle\DependencyInjection\Compiler;
 
 use Exception;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 
 class GeneratorPass implements CompilerPassInterface

diff --git a/src/DependencyInjection/Compiler/PathReducerPass.php b/src/DependencyInjection/Compiler/PathReducerPass.php
@@ -3,8 +3,8 @@
 namespace Tienvx\Bundle\MbtBundle\DependencyInjection\Compiler;
 
 use Exception;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 
 class PathReducerPass implements CompilerPassInterface

diff --git a/src/DependencyInjection/Compiler/SecurityTokenPass.php b/src/DependencyInjection/Compiler/SecurityTokenPass.php
@@ -3,14 +3,14 @@
 namespace Tienvx\Bundle\MbtBundle\DependencyInjection\Compiler;
 
 use Exception;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 use Tienvx\Bundle\MbtBundle\Command\CaptureScreenshotsCommand;
 use Tienvx\Bundle\MbtBundle\Command\ExecuteTaskCommand;
 use Tienvx\Bundle\MbtBundle\Command\GeneratePathCommand;
-use Tienvx\Bundle\MbtBundle\Command\ReducePathCommand;
 use Tienvx\Bundle\MbtBundle\Command\ReduceBugCommand;
+use Tienvx\Bundle\MbtBundle\Command\ReducePathCommand;
 
 class SecurityTokenPass implements CompilerPassInterface
 {

diff --git a/src/DependencyInjection/Compiler/SubjectPass.php b/src/DependencyInjection/Compiler/SubjectPass.php
@@ -3,9 +3,8 @@
 namespace Tienvx\Bundle\MbtBundle\DependencyInjection\Compiler;
 
 use Exception;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
-use Symfony\Component\DependencyInjection\Exception\RuntimeException;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectInterface;
 
 class SubjectPass implements CompilerPassInterface

diff --git a/src/DependencyInjection/TienvxMbtExtension.php b/src/DependencyInjection/TienvxMbtExtension.php
@@ -9,8 +9,8 @@
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Tienvx\Bundle\MbtBundle\Command\ExecuteTaskCommand;
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorInterface;
-use Tienvx\Bundle\MbtBundle\Generator\RandomGenerator;
 use Tienvx\Bundle\MbtBundle\Generator\ProbabilityGenerator;
+use Tienvx\Bundle\MbtBundle\Generator\RandomGenerator;
 use Tienvx\Bundle\MbtBundle\PathReducer\PathReducerInterface;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectInterface;
 

diff --git a/src/Event/ReducerFinishEvent.php b/src/Event/ReducerFinishEvent.php
diff --git a/src/EventListener/EntitySubscriber.php b/src/EventListener/EntitySubscriber.php
@@ -8,8 +8,8 @@
 use Symfony\Component\Messenger\MessageBusInterface;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Entity\Task;
-use Tienvx\Bundle\MbtBundle\Message\ReduceBugMessage;
 use Tienvx\Bundle\MbtBundle\Message\ExecuteTaskMessage;
+use Tienvx\Bundle\MbtBundle\Message\ReduceBugMessage;
 use Tienvx\Bundle\MbtBundle\Message\RemoveScreenshotsMessage;
 
 class EntitySubscriber implements EventSubscriber

diff --git a/src/EventListener/WorkflowSubscriber.php b/src/EventListener/WorkflowSubscriber.php
@@ -2,8 +2,8 @@
 
 namespace Tienvx\Bundle\MbtBundle\EventListener;
 
-use Exception;
 use Doctrine\Common\Annotations\Reader;
+use Exception;
 use ReflectionMethod;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Workflow\Event\Event;

diff --git a/src/Generator/AbstractGenerator.php b/src/Generator/AbstractGenerator.php
@@ -2,9 +2,7 @@
 
 namespace Tienvx\Bundle\MbtBundle\Generator;
 
-use Generator;
 use Symfony\Component\Workflow\Exception\TransitionException;
-use Symfony\Component\Workflow\Transition;
 use Symfony\Component\Workflow\Workflow;
 use Tienvx\Bundle\MbtBundle\Subject\AbstractSubject;
 

diff --git a/src/Maker/MakeGenerator.php b/src/Maker/MakeGenerator.php
@@ -2,7 +2,6 @@
 
 namespace Tienvx\Bundle\MbtBundle\Maker;
 
-use Doctrine\Common\Annotations\Annotation;
 use Symfony\Bundle\MakerBundle\ConsoleStyle;
 use Symfony\Bundle\MakerBundle\DependencyBuilder;
 use Symfony\Bundle\MakerBundle\Generator;

diff --git a/src/Maker/MakePathReducer.php b/src/Maker/MakePathReducer.php
@@ -2,7 +2,6 @@
 
 namespace Tienvx\Bundle\MbtBundle\Maker;
 
-use Doctrine\Common\Annotations\Annotation;
 use Symfony\Bundle\MakerBundle\ConsoleStyle;
 use Symfony\Bundle\MakerBundle\DependencyBuilder;
 use Symfony\Bundle\MakerBundle\Generator;

diff --git a/src/Service/GraphBuilder.php b/src/Service/GraphBuilder.php
@@ -6,8 +6,8 @@
 use Fhaculty\Graph\Graph;
 use Fhaculty\Graph\Vertex;
 use Graphp\Algorithms\ConnectedComponents;
-use Psr\SimpleCache\CacheInterface;
 use Psr\SimpleCache\CacheException;
+use Psr\SimpleCache\CacheInterface;
 use Symfony\Component\Workflow\StateMachine;
 use Symfony\Component\Workflow\Transition;
 use Symfony\Component\Workflow\Workflow;

diff --git a/src/Validator/Constraints/PathValidator.php b/src/Validator/Constraints/PathValidator.php
@@ -31,7 +31,7 @@ public function validate($value, Constraint $constraint)
             GraphPath::unserialize($value);
         } catch (Exception $exception) {
             $this->context->buildViolation($constraint->message)
-                ->setParameter('{{ string }}', $value)
+                ->setParameter('{{ string }}', json_encode($value))
                 ->addViolation();
         }
     }

diff --git a/src/Validator/Constraints/ReducerValidator.php b/src/Validator/Constraints/ReducerValidator.php
@@ -5,7 +5,6 @@
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
-use Tienvx\Bundle\MbtBundle\Generator\GeneratorManager;
 use Tienvx\Bundle\MbtBundle\PathReducer\PathReducerManager;
 
 /**

diff --git a/src/Validator/Constraints/Unique.php b/src/Validator/Constraints/Unique.php
diff --git a/src/Validator/Constraints/UniqueValidator.php b/src/Validator/Constraints/UniqueValidator.php
diff --git a/tests/Message/BugMessageTest.php b/tests/Message/BugMessageTest.php
@@ -3,7 +3,6 @@
 namespace Tienvx\Bundle\MbtBundle\Tests\Message;
 
 use Doctrine\ORM\EntityManagerInterface;
-use Symfony\Component\Console\Tester\CommandTester;
 use Tienvx\Bundle\MbtBundle\Entity\Bug;
 use Tienvx\Bundle\MbtBundle\Entity\Task;
 use Tienvx\Bundle\MbtBundle\Graph\Path;

diff --git a/tests/app/src/Command/CommandRunner.php b/tests/app/src/Command/CommandRunner.php
@@ -4,7 +4,6 @@
 
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\StringInput;
 use Symfony\Component\Console\Output\NullOutput;
 use Tienvx\Bundle\MbtBundle\Command\CommandRunner as BaseCommandRunner;