Skip to content

Commit

Permalink
Merge pull request #462 from tienvx/use-phpunit-9
Browse files Browse the repository at this point in the history
Use phpunit 9
  • Loading branch information
tienvx committed Feb 29, 2020
2 parents 53b2b71 + 95e5a17 commit 69c186a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: ['7.2', '7.3', '7.4']
php: ['7.3', '7.4']
container:
image: php:${{ matrix.php }}-cli-alpine
steps:
Expand All @@ -53,9 +53,7 @@ jobs:

- name: Test & Generate Code Coverage
run: |
wget -q -O phpunit https://phar.phpunit.de/phpunit-8.phar
chmod +x phpunit
./phpunit -d memory_limit=512M --coverage-clover tests/logs/clover.xml
./vendor/bin/phpunit -d memory_limit=512M --coverage-clover tests/logs/clover.xml
- name: Send to coveralls
run: |
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ All you have to do:

## Requirements

* PHP 7.2 / 7.3 / 7.4
* PHP 7.3 / 7.4
* Symfony 5.0
* See also the `require` section of [composer.json](composer.json)

Expand Down Expand Up @@ -69,7 +69,7 @@ the way to tell this bundle to interact with your application.
You can run the tests with:
```console
$ php tests/app/bin/console cache:clear # Only if you added new code
$ phpunit
$ vendor/bin/phpunit
```

## Validate code with coding standards
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}
],
"require": {
"php": "^7.2.5",
"php": "^7.3",
"ext-json": "*",
"symfony/framework-bundle": "~5.0.1",
"symfony/console": "~5.0.1",
Expand All @@ -35,6 +35,7 @@
"jmgq/a-star": "^1.1"
},
"require-dev": {
"phpunit/phpunit": "~9.0.1",
"symfony/yaml": "~5.0.1",
"symfony/expression-language": "~5.0.1",
"symfony/security-core": "~5.0.1",
Expand Down
2 changes: 1 addition & 1 deletion tests/Message/TaskMessageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function testExecute(string $model, string $generator, string $reducer, b
$ids = [];
foreach ($bugs[0]->getSteps() as $step) {
if ($step->getData() && $step->getData()->has('product')) {
$ids[] = $step->getData()->get('product');
$ids[] = (int) $step->getData()->get('product');
}
}
if ('You added an out-of-stock product into cart! Can not checkout' === $bugs[0]->getBugMessage()) {
Expand Down

0 comments on commit 69c186a

Please sign in to comment.