Merge pull request #479 from tienvx/remove-subject-event

Remove subject event
tienvx · May 14, 2020 · 178c233 · 178c233
2 parents ab8817c + 3a2d018
commit 178c233
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 76 deletions.
diff --git a/src/Command/WorkflowTryCommand.php b/src/Command/WorkflowTryCommand.php
@@ -15,6 +15,7 @@
 use Tienvx\Bundle\MbtBundle\Generator\GeneratorManager;
 use Tienvx\Bundle\MbtBundle\Helper\Steps\Recorder as StepsRecorder;
 use Tienvx\Bundle\MbtBundle\Helper\WorkflowHelper;
+use Tienvx\Bundle\MbtBundle\Model\Subject\TearDownInterface;
 use Tienvx\Bundle\MbtBundle\Model\SubjectInterface;
 use Tienvx\Bundle\MbtBundle\Steps\Steps;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
@@ -97,7 +98,9 @@ protected function try(GeneratorInterface $generator, GeneratorOptions $generato
                 "<error>{$throwable->getMessage()}</error>",
             ]);
         } finally {
-            $subject->tearDown();
+            if ($subject instanceof TearDownInterface) {
+                $subject->tearDown();
+            }
         }
 
         $this->renderTable($output, $recorded);

diff --git a/src/Event/SubjectInitEvent.php b/src/Event/SubjectInitEvent.php
diff --git a/src/EventListener/SubjectSubscriber.php b/src/EventListener/SubjectSubscriber.php
diff --git a/src/MessageHandler/ExecuteTaskMessageHandler.php b/src/MessageHandler/ExecuteTaskMessageHandler.php
@@ -14,6 +14,7 @@
 use Tienvx\Bundle\MbtBundle\Helper\WorkflowHelper;
 use Tienvx\Bundle\MbtBundle\Message\ApplyTaskTransitionMessage;
 use Tienvx\Bundle\MbtBundle\Message\ExecuteTaskMessage;
+use Tienvx\Bundle\MbtBundle\Model\Subject\TearDownInterface;
 use Tienvx\Bundle\MbtBundle\Steps\Steps;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
 use Tienvx\Bundle\MbtBundle\Workflow\TaskWorkflow;
@@ -98,7 +99,9 @@ protected function execute(Task $task): void
         } catch (Throwable $throwable) {
             $this->messageHelper->createBug($recorded, $throwable->getMessage(), $task->getId(), $task->getWorkflow()->getName());
         } finally {
-            $subject->tearDown();
+            if ($subject instanceof TearDownInterface) {
+                $subject->tearDown();
+            }
 
             $this->messageBus->dispatch(new ApplyTaskTransitionMessage($task->getId(), TaskWorkflow::COMPLETE));
         }

diff --git a/src/MessageHandler/TestBugMessageHandler.php b/src/MessageHandler/TestBugMessageHandler.php
@@ -15,6 +15,7 @@
 use Tienvx\Bundle\MbtBundle\Helper\WorkflowHelper;
 use Tienvx\Bundle\MbtBundle\Message\ApplyBugTransitionMessage;
 use Tienvx\Bundle\MbtBundle\Message\TestBugMessage;
+use Tienvx\Bundle\MbtBundle\Model\Subject\TearDownInterface;
 use Tienvx\Bundle\MbtBundle\Steps\Steps;
 use Tienvx\Bundle\MbtBundle\Subject\SubjectManager;
 use Tienvx\Bundle\MbtBundle\Workflow\BugWorkflow;
@@ -88,7 +89,9 @@ public function __invoke(TestBugMessage $message): void
         } catch (Throwable $throwable) {
             $this->handleThrowable($throwable, $bug, $recorded);
         } finally {
-            $subject->tearDown();
+            if ($subject instanceof TearDownInterface) {
+                $subject->tearDown();
+            }
         }
     }
 

diff --git a/src/MessageHandler/TestPredefinedCaseMessageHandler.php b/src/MessageHandler/TestPredefinedCaseMessageHandler.php
@@ -10,6 +10,7 @@
 use Tienvx\Bundle\MbtBundle\Helper\Steps\Recorder as StepsRecorder;
 use Tienvx\Bundle\MbtBundle\Helper\WorkflowHelper;
 use Tienvx\Bundle\MbtBundle\Message\TestPredefinedCaseMessage;
+use Tienvx\Bundle\MbtBundle\Model\Subject\TearDownInterface;
 use Tienvx\Bundle\MbtBundle\Model\SubjectInterface;
 use Tienvx\Bundle\MbtBundle\PredefinedCase\PredefinedCaseManager;
 use Tienvx\Bundle\MbtBundle\Steps\Steps;
@@ -80,7 +81,9 @@ protected function test(PredefinedCase $predefinedCase, SubjectInterface $subjec
         } catch (Throwable $throwable) {
             $this->messageHelper->createBug($recorded, $throwable->getMessage(), null, $workflowName);
         } finally {
-            $subject->tearDown();
+            if ($subject instanceof TearDownInterface) {
+                $subject->tearDown();
+            }
         }
     }
 }
diff --git a/src/Subject/SubjectManager.php b/src/Subject/SubjectManager.php
@@ -3,8 +3,7 @@
 namespace Tienvx\Bundle\MbtBundle\Subject;
 
 use Exception;
-use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
-use Tienvx\Bundle\MbtBundle\Event\SubjectInitEvent;
+use Tienvx\Bundle\MbtBundle\Model\Subject\SetUpInterface;
 use Tienvx\Bundle\MbtBundle\Model\SubjectInterface;
 
 class SubjectManager
@@ -14,15 +13,9 @@ class SubjectManager
      */
     protected $subjects;
 
-    /**
-     * @var EventDispatcherInterface
-     */
-    protected $dispatcher;
-
-    public function __construct(array $subjects, EventDispatcherInterface $dispatcher)
+    public function __construct(array $subjects)
     {
         $this->subjects = $subjects;
-        $this->dispatcher = $dispatcher;
     }
 
     public function create(string $workflowName, bool $trying = false): SubjectInterface
@@ -33,8 +26,9 @@ public function create(string $workflowName, bool $trying = false): SubjectInter
         }
 
         $subject = new $class();
-        $event = new SubjectInitEvent($subject, $trying);
-        $this->dispatcher->dispatch($event, SubjectInitEvent::NAME);
+        if ($subject instanceof SetUpInterface) {
+            $subject->setUp($trying);
+        }
 
         return $subject;
     }