Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert readxl from Rcpp to cpp11 #659
Convert readxl from Rcpp to cpp11 #659
Changes from 8 commits
40d1300
2a20277
0faa29a
aa0523a
ca4ca54
ec7c62c
7480b9a
1278c16
0e48fb4
8299cd7
4e6aab5
8574e0c
3f7553f
0470661
79fc036
5f07e14
988bb94
51a5957
33d6136
d6bf9a3
a50c859
7c8ad23
8bc4c5c
deecf96
9215609
24a8970
51e82a9
db8fc06
1f20ad9
2842599
33c79a5
5aaf592
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make more sense to keep the system includes, e.g.
<whatever>
together and above the ones defined here, e.g."utils.h"
?If you agree, that would be a good thing to check globally. I think that is (mostly?) how things started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Thank you for reminding me about this.
I rearranged some of the header files to avoid conflicts with Rcpp and cpp11 libraries so I need to reorganize them (or organize them back to how you had them). I ended up using the macros
#define R_NO_REMAP
and#define STRICT_R_HEADERS
instead to avoid the conflicts, which I'll remove since they won't be needed anymore once this PR is closed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state seems to be much more regular, but often puts the local headers before the system headers. It feels like a more conventional order would be: system, vendored code (libxls), written-by-us, which also reflects intended precedence. (Let me also acknowledge that this probably doesn't matter and is more a matter of style at this point.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes sorry! I should have reread your comment before executing based on my memory. I'll rearrange in that order.