Accept XLSX files that do not contain a "styles" part #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open an issue with a bit more background and an example of a file with this quality? I don't believe I've ever seen this phenomenon. We'd also need related tests. |
…e#506 An XLSX file that does not contain a "styles" part triggers this error: > read_excel("foo.xlsx", sheet="Sheet1") Error in sheets_fun(path) : Evaluation error: Couldn't find '' in 'foo.xlsx'. To fix this, check for the presence of the part in cacheDateFormats() in the same way that cacheStringTable() does.
|
Thank you for your feedback. I've submitted issue #506 and added a test case to my proposed fix. |
|
Is there anything I can do to move this issue forward? |
|
We work on things in cycles and readxl is not in such a phase right now. But I'll try to take a look to get you unstuck. |
jennybc
added a commit
that referenced
this pull request
Dec 12, 2018
* Accept XLSX files that do not contain a "styles" part; fixes #506 An XLSX file that does not contain a "styles" part triggers this error: > read_excel("foo.xlsx", sheet="Sheet1") Error in sheets_fun(path) : Evaluation error: Couldn't find '' in 'foo.xlsx'. To fix this, check for the presence of the part in cacheDateFormats() in the same way that cacheStringTable() does. * Rename test sheet; code style * Beef up the test a bit * Add NEWS bullet
|
Thanks! I made a few small changes. Usually I can push back into someone's PR but that did not work here. So I continued in an internal branch and merged. You are credited in the NEWS. |
|
In future and in general, it is best if you make a pull request from a non- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An XLSX file that does not contain a "styles" part triggers this error:
To fix this, mimic the check that cacheStringTable() performs also in
cacheDateFormats().