Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow multiple values for na #13

Closed
sachsmc opened this issue Mar 19, 2015 · 8 comments
Closed

Feature request: allow multiple values for na #13

sachsmc opened this issue Mar 19, 2015 · 8 comments
Labels
feature a feature request or enhancement

Comments

@sachsmc
Copy link

sachsmc commented Mar 19, 2015

E.g. na = c("NA", "N/A")

@jakesherman
Copy link

Seconded.

@sunitj
Copy link

sunitj commented Apr 9, 2015

👍 Came here to make the same request. Glad I'm not the only one.

@mattsigal
Copy link

I would also love to see this implemented!

@jennybc
Copy link
Member

jennybc commented May 23, 2015

👍

@MichaelChirico
Copy link
Contributor

Also would like this. Can't imagine it's too hard to implement either... any particular hold-up? I'd be happy to help if I was more fluent in C++...

@MichaelChirico
Copy link
Contributor

Seems like the crux of the issue is in the XlsxCell class/methods definition, where an NA is produced with the condition (in the type, asDate, asDouble, and asCharSxp methods):

@MichaelChirico
Copy link
Contributor

The version I've got on my branch is now functional (see Pull Request).

If you're impatient you can use the version on my branch (via install_github("MichaelChirico/readxl@multiple_na")). I'm not sure the procedure for documentation / tests around here, so it may need a bit of polishing before it's officially merged.

@yimingli
Copy link

+1

@jennybc jennybc added the feature a feature request or enhancement label Jan 7, 2017
@lock lock bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

7 participants