MdePkg/BaseLib: Add CRC16 CCITT False Implementation. #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you list more detail on the consumer code, such as BDAT table? |
Some embedded controllers require the CRC16 CCITT false algorithm for their communication packets. JEDEC also seems to favor this, as it is called out in EMMc specification, and SPD specificaitons. |
lgao4
approved these changes
Aug 6, 2024
This change is added to incorporate basic implementation for CRC16-CCITT-FALSE algorithm. This function is useful for providing CRC16 value used in other data structures that requires CRC16 value that complies with JEDEC SPD requirements, i.e. BDAT table. The lookup table is inherited from `https://crccalc.com/` and the result values are also compared against this site. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
lgao4
force-pushed
the
personal/apop5/CRC16
branch
from
df32af6
to
86c96d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is added to incorporate basic implementation for CRC16-CCITT-FALSE algorithm.
This function is useful for providing CRC16 value used in other data structures that requires CRC16 values.
JEDEC specifications for BDAT, eMMC and SPD callout this algorithm.
The lookup table is inherited from
https://crccalc.com/and the result values are also compared against this site.How This Was Tested
Using BaseLib function, results were verified against the values generated on crccalc.com
Integration Instructions
N/A