Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseTools: Add VS2022 support. #5799

Merged
merged 2 commits into from
Jul 8, 2024
Merged

BaseTools: Add VS2022 support. #5799

merged 2 commits into from
Jul 8, 2024

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 20, 2024

Description

Adding support for VS2022 build tools.

Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

  • Breaking change?
    • Breaking change - Will this cause a break in build or boot behavior?
    • Examples: Add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does the change have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Ran build on local system (tool_chain_target=vs2022)
Ran CI on local system (tool_chain_target=vs2022).
Both tests found vs2022.

Integration Instructions

N/A

@apop5 apop5 marked this pull request as ready for review June 20, 2024 01:16
@apop5
Copy link
Contributor Author

apop5 commented Jun 20, 2024

@bcran

can you please take a look at this when you get a chance?

@bcran bcran self-requested a review June 20, 2024 01:44
@bcran bcran changed the title BuildTools: Add VS2022 support. BaseTools: Add VS2022 support. Jun 20, 2024
bcran
bcran reviewed Jun 20, 2024
View reviewed changes
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py Show resolved Hide resolved
BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py Show resolved Hide resolved
BaseTools/set_vsprefix_envs.bat Outdated Show resolved Hide resolved
@bcran bcran requested a review from lgao4 June 20, 2024 02:01
@matthewfcarlson @apop5
BaseTools: Add VS2022 support.
36c019a 
Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
@apop5
Copy link
Contributor Author

apop5 commented Jul 3, 2024

@bcran @lgao4

Do you have any other concerns?

@os-d os-d mentioned this pull request Jul 5, 2024
Closed
3 tasks
@bcran bcran added the push Auto push patch series in PR if all checks pass label Jul 8, 2024
@mergify mergify bot merged commit 95a6892 into tianocore:master Jul 8, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgao4 lgao4 lgao4 left review comments

@os-d os-d os-d left review comments

@bcran bcran bcran approved these changes

Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apop5 @bcran @lgao4 @os-d @matthewfcarlson