-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to show or hide read posts #921
Conversation
I noticed that too - I can see if I can shrink it down a bit more!
Good idea, I'll see if I can add that in quickly |
Looks great! I wonder if we even need the "you are current viewing..." or if it would be sufficient to have the user widget at the top (maybe above the first paragraph). But I'll leave that up to you. It's good as is! |
Yeah that looks really nice!! P.S. It looks like there's an error on this page in 0.19. Not sure if it's new, so it can probably be addressed separately. |
Hmm, what's the error? I can't reproduce it on my end |
Voyager seems to be having some issues at the moment, so I can't log in, but I will try again when I can! |
Here you go, let me know if this helps! Code_nFHhcnupP3.mp4 |
Just curious, but are you able to login to voyager.lemmy.ml (on the web UI)? I think the server was reset a while back so all existing accounts there were deleted. I had to create a new account to log in because I had issues using my old credentials. |
Yes I also had to recreate my account a while back, and yes I can still log into the web UI. However, I tried logging out in Thunder and back in, and that seemed to fix the issue. So I'll just blame it on some Voyager weirdness. 😊 Thanks! |
Ahh, maybe it was keeping the old JWT token around still which caused it to not work? Either way, I think it should be good since you were able to resolve it! |
Pull Request Description
This PR introduces a setting to toggle on and off read posts which syncs up with the currently active Lemmy account. I've added the general logic to allow fetching and updating the current user's account settings. This will allow us to more easily add in options in the future on a per-account basis.
Since this setting is synced with the Lemmy account, there's no additional logic required to check if the given post being fetched has been read or not.
An idea for a future improvement would be a account selector within this page to allow us to switch between the different logged-in accounts.
Issue Being Fixed
Issue Number: #913
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?