Fix sidebar lag when subscribed to a large amount of communities #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed search page subscription refresh
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where the drawer experiences lag when there are a large amount of subscribed communities. To do this, I migrated over to using slivers and a CustomScrollView which improves scrolling performance.
Additionally, I fixed an issue with the search page where if you subscribe to a community while in the "View All" view, it would refresh and reset the view back to the trending view.
Issue Being Fixed
Issue Number: #1450
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?