Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional account settings #1436

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jun 8, 2024

Pull Request Description

This PR adds a bunch of additional account settings that sync up with Lemmy, including:

  • Display name
  • Profile bio
  • Email
  • Matrix user ID
  • Default feed type - this setting will override the existing app setting
  • Default feed sort - this setting will override the existing app setting
  • Show NSFW content

As a result of this, I also cleaned up the user settings page and moved discussion languages and blocking to separate pages.

Note: I opted to only sync settings that adjust underlying logic. I left out most of the settings which change the UI in some way (since I believe that's better handled in the app settings). These are the settings I omitted from including:

  • Interface language
  • theme
  • Blur NSFW content
  • Auto-expand media
  • Show Avatars
  • Bot account toggle
  • Show notifications for new posts
  • Send notifications to email
  • Open links in a new tab

Some settings that are still missing but would be good to add in the future include:

  • Avatar
  • Banner
  • Two-factor auth
  • Exporting/importing settings

I did some basic testing for all of the new settings introduced, but there might still be some edge cases I missed!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Account Settings

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.13.51.1.mp4

Discussion Languages

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.19.11.mp4

Block Management

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.22.19.mp4

Feed Account Sort/Type
Keep an eye out on the feed sort type

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.29.09.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I love all the new settings, the reorganization of the content management section, the use of the FAB and tabs.

Here are just a few initial thoughts from watching the demo videos. Any/all of these things can be separate.

  • In General Settings, should "Default Comment Sort Type" go under "Comments" rather than "Feed"?
  • In the list of settings you said you didn't add because they mostly related to the web UI, one I disagree with is "Bot account toggle" which marks your own account as being a bot. I see a lot of people have this on by accident, so it might be nice to allow it to be toggled off in Thunder.
  • I believe bios support markdown, so you might want to consider sanitizing the content for the subtitle. You might also want to truncate it, since bios may be long.

@hjiangsu
Copy link
Member Author

Alright, I addressed most of the comments you had!

  • Moved "Default Comment Sort Type" top "Comments"
  • Added "Bot" to user account settings

I believe bios support markdown, so you might want to consider sanitizing the content for the subtitle. You might also want to truncate it, since bios may be long.

For this, I expanded the text field to allow for multiple lines, and truncated/sanitized the bio preview. For now, it's still using a simple text field even though markdown is supported but we can add in markdown support for bios in a future PR!

@micahmo
Copy link
Member

micahmo commented Jun 10, 2024

Awesome, the changes look good!!

@hjiangsu hjiangsu merged commit d6b66b1 into develop Jun 10, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/additional-account-settings branch June 10, 2024 19:51
@micahmo
Copy link
Member

micahmo commented Jun 10, 2024

@hjiangsu I noticed a slight quirk here.

image

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants