Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user/community display name setting #1376

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 22, 2024

Pull Request Description

Previously, the option to show a use "display names" was only available for user names within the feed. This PR makes that setting part of the global name formatting options, so it will apply anywhere the full name widgets are used (with some intentional exceptions). I've also added a similar option for communities.

Note that this setting is ignored in places where we already show the display name (e.g., profile pages, autocomplete results, etc.).

qemu-system-x86_64_TKduIclfH3.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just have one minor comment otherwise LGTM!

lib/shared/chips/community_chip.dart Show resolved Hide resolved
@hjiangsu hjiangsu merged commit 1789fc8 into thunder-app:develop Jun 25, 2024
1 check passed
@micahmo micahmo deleted the feature/global-display-name-setting branch June 25, 2024 16:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants