Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional styling to no-thumbnail mode #1326

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR is just a follow up to #1302. It applies a bit more styling to the no-thumbnail mode to make it feel more consistent with our overall UI. There were just a few quirks that I ran into when using this mode!

  • Applied some padding to the post feed card when no thumbnails is on (compact mode)
  • Rounded the corners of the InkWell and fixed an issue where the InkWell tap was not extending to the whole LinkInformation container
  • Added the link handling for MediaType.link (with long press modal)

Some misc changes are included here too:

  • Made the image failure logic use the new LinkInformation widget to be consistent

Review with whitespace off

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before After
IMG_1691 IMG_1689
IMG_1690 IMG_1687

Before (tap/long press handling):

RPReplay_Final1713987953.mp4

After (tap/long press handling):

RPReplay_Final1713987975.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catches!

@hjiangsu hjiangsu merged commit b4f9bd4 into develop Apr 24, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/no-thumbnail-improvements branch April 24, 2024 20:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants