Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loading page for posts/comments #1311

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 17, 2024

Pull Request Description

This PR adds the loading page feature for post and comment links. The loading page was originally added in #1200, and it was to handle the case where we have an ambiguous link for a person or community, so we load the full object to verify whether it really exists before navigating. The loading page helps to bridge the gap while we fetch the object so the user knows something is happening.

I've been noticing that navigating to posts and comments has a similar problem where there seems to be no activity for a period of time (especially on a slower network). I believe this is because we similarly load the whole post/comment object before navigating, and unlike users/communities, we always load posts/comments, making the problem even more obvious. Furthermore, we often have to do a ResolveObject if the entity is on a different instance.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

post-comment-loading-before.mp4

After

post-comment-loading-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment!

lib/shared/pages/loading_page.dart Show resolved Hide resolved
@hjiangsu hjiangsu merged commit 8106060 into thunder-app:develop Apr 18, 2024
1 check passed
@micahmo micahmo deleted the feature/post-comment-loading-page branch April 18, 2024 17:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants