Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with comment load spinner #1278

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 5, 2024

Pull Request Description

I've been noticing lately that comment threads have been having a spinner at the bottom, despite having loaded all the comments. I believe this behavior might have regressed as a result of #1107, in which I tweaked the code to fix an issue with deferred comments. I'm not sure if that change broke this case, or really just exposed an unexpected behavior, which is that our state.commentCount is greater than the postView.counts.comments. I can't explain how that can be, but I think the fix is to consider all the comments loaded if our count is greater than or equal (not just equal).

Here is the post I tested with, for reference: https://midwest.social/post/10198542

I will keep an eye out to see whether this fix now regresses the other one!

Issue Being Fixed

Before

comment-issue-before.mp4

After

comment-issue-after.mp4

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm not too sure what causes this issue either. Either way, LGTM!

@hjiangsu hjiangsu merged commit 8e65447 into thunder-app:develop Apr 10, 2024
1 check passed
@micahmo micahmo deleted the fix/comment-load-issue branch April 10, 2024 18:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants