Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(polkadot): upgrade to v1.1.0 #902

Merged
merged 32 commits into from
Aug 26, 2024
Merged

Conversation

renauter
Copy link
Collaborator

@renauter renauter commented Nov 30, 2023

Description

  • Upgrade to Polkadot v1.1.0
    • remove try-runtime from node cli
    • add type MaxNominators to pallet_grandpa::Config
    • grandpa: avoid importing unnecessary justifications
    • vec, Vec, Box, Zero were removed from frame_benchmarking
    • Dispatchable, DispatchError, bounded_vec were removed from frame_support
    • add sp-weights dependency to get access to Weight
    • change RuntimeDebug to pallet_prelude::RuntimeDebug
    • add log dependency to pallet-tft-bridge
    • add sp-state-machine dependency to substrate-validator-set to get BasicExternalities

Related Issues:

Checklist:

Please delete options that are not relevant.

@renauter renauter changed the base branch from development to feat_upgrade_polkadot-1.0.0 November 30, 2023 13:46
@renauter renauter changed the title Feat upgrade polkadot 1.1.0 feat(polkadot): upgrade to v1.1.0 Nov 30, 2023
@renauter renauter marked this pull request as ready for review November 30, 2023 14:38
@renauter renauter changed the title feat(polkadot): upgrade to v1.1.0 chore(polkadot): upgrade to v1.1.0 Dec 2, 2023
Base automatically changed from feat_upgrade_polkadot-1.0.0 to development December 6, 2023 15:27
@renauter
Copy link
Collaborator Author

renauter commented Dec 12, 2023

After running:

try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/ws

I have such result:

image

triggered here by the pallet_session_historical migration to v1 which returns <T as frame_system::Config>::BlockWeights::get().max_block

But not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.

@sameh-farouk
Copy link
Member

After running:

try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/ws

I have such result:

image

triggered here by the pallet_session_historical migration to v1 which returns <T as frame_system::Config>::BlockWeights::get().max_block

But not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.

To my understanding this migration toke slight longer than ref time ? how it could bad if ran against mainnet state? could you check?

@renauter renauter requested review from sameh-farouk and removed request for LeeSmet and sameh-farouk August 23, 2024 15:27
@sameh-farouk
Copy link
Member

sameh-farouk commented Aug 23, 2024

I'm having trouble getting past this error in this branch when attempting to build it. Any idea?

error: no matching package named `bandersnatch_vrfs` found
location searched: https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b
required by package `sp-core v21.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.1.0#f60318f6)`
    ... which satisfies git dependency `sp-core` (locked to 21.0.0) of package `tfchain v2.8.1 (/home/sameh/Projects/tfchain/substrate-node/node)`

Update: Never mind, got it to work.

@sameh-farouk
Copy link
Member

There isn't any runtime migration required to update to Polkadot v1.1.0, right?

@sameh-farouk
Copy link
Member

LGTM
Thank you @renauter

@renauter
Copy link
Collaborator Author

There isn't any runtime migration required to update to Polkadot v1.1.0, right?

When executing try-runtime I don't have log of any storage version incompatibility version like we had previously here

Also I checked for eventual required migrations in Polkadot v1.1.0 analysis
https://forum.polkadot.network/t/polkadot-release-analysis-v1-1-0/3988#runtime-migrations-3
and there are only some migrations for pallet-contracts which is not in our dependency tree.

So we should be good on migration side

@renauter renauter merged commit 2f06d6f into development Aug 26, 2024
3 checks passed
@renauter renauter deleted the feat_upgrade_polkadot_1.1.0 branch August 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime: update to polkadot 1.1.0
2 participants