Run prettier on project. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geekiam23
commented
May 10, 2023
geekiam23
commented
- Run prettier on project to use single quotes.
stevehanson
reviewed
May 11, 2023
|
@geekiam23 what is the status of this PR? I'd like to either close this or move the PR forward so we can get this in or so someone else can pick it up. |
geekiam23
force-pushed
the
create-prettier-path
branch
from
da9b76e
to
c576c27
Compare
Commander can automatically import files for us by specifying 'executableFile' for commands. This unfortunately doesn't work well with TypeScript, which was why we were using `node -r ts-node` to run the CLI instead of `ts-node`. This setup to get commander working was also causing other issues with file imports. This commit updates so we now manually import files for commands, which enables us to revert the less-conventional TypeScript config.
- Setup inquirer to ask questions about prettier config - If prettierrc/prettier.js or .prettierignore exists, it will not create any new files. - Add ts-node key to tsconfig.json to help with node typescript errors. - Add .prettierignore.template to use to write to .prettierignore. - Add formatFile to format any files we add to the project. - Add getProjectDir to get main directory of project.
Since the tool is only React Native for now, it didn't seem necessary to have the 'react-native' directory. Moved to 'src'. Also created utility for importing commands for commander
- Setup inquirer to ask questions about prettier config - If prettierrc/prettier.js or .prettierignore exists, it will not create any new files. - Add ts-node key to tsconfig.json to help with node typescript errors. - Add .prettierignore.template to use to write to .prettierignore. - Add formatFile to format any files we add to the project. - Add getProjectDir to get main directory of project.
geekiam23
force-pushed
the
run-prettier
branch
from
1f262d5
to
9e2bd4c
Compare
geekiam23
force-pushed
the
create-prettier-path
branch
from
62d3dd2
to
c4886b9
Compare
stevehanson
reviewed
Aug 17, 2023
* Add eslint path * Run linter * Remove log * Remove extra formatting file * Update to use thoughtbot eslint package * Remove overrides in template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.