Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added option for starts_with filter on /python/package #1765

Merged
merged 3 commits into from
Jun 3, 2022
Merged

added option for starts_with filter on /python/package #1765

merged 3 commits into from
Jun 3, 2022

Conversation

Gkrumbach07
Copy link
Member

Related Issues and Dependencies

#1743

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

Added a new optional parameter to the /python/package endpoint called start_with.

Description

starts_with will filter the query to only include packages that have a name that starts with starts_with input value

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2022
mayaCostantini
mayaCostantini approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@mayaCostantini mayaCostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! 💯

fridex
fridex reviewed May 24, 2022
View reviewed changes
thoth/user_api/api_v1.py Outdated Show resolved Hide resolved
@Gkrumbach07 Gkrumbach07 requested a review from fridex May 31, 2022 12:21
@sesheta
Copy link
Member

sesheta commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@harshad16
Copy link
Member

/test all

3 similar comments
@Gkrumbach07
Copy link
Member Author

/test all

@Gkrumbach07
Copy link
Member Author

/test all

@harshad16
Copy link
Member

/test all

@sesheta sesheta merged commit 23a2f0e into thoth-station:master Jun 3, 2022
@harshad16 harshad16 mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayaCostantini mayaCostantini mayaCostantini approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@fridex fridex Awaiting requested review from fridex

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gkrumbach07 @sesheta @harshad16 @fridex @mayaCostantini