Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and polish OpenAPI schema #1590

Closed
wants to merge 1 commit into from

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jan 7, 2022

Related Issues and Dependencies

Fixes: #1588

This introduces a breaking change

  • No

Description

Review OpenAPI schema, add missing parts, and polish it.

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 7, 2022
@sesheta
Copy link
Member

sesheta commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fridex fridex marked this pull request as draft January 7, 2022 00:21
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2022
@fridex fridex force-pushed the openapi-update branch 2 times, most recently from 766228e to 0e8f897 Compare January 10, 2022 11:22
@fridex fridex force-pushed the openapi-update branch 2 times, most recently from a727d19 to 0c2024b Compare January 11, 2022 10:14
@harshad16 harshad16 removed their request for review January 11, 2022 14:01
@fridex fridex force-pushed the openapi-update branch 2 times, most recently from 98a9e2b to 6ca6eef Compare January 11, 2022 21:50
@fridex
Copy link
Contributor Author

fridex commented Jan 11, 2022

/deploy

@fridex
Copy link
Contributor Author

fridex commented Jan 12, 2022

/close

Closing, adjusted in #1597

@sesheta sesheta closed this Jan 12, 2022
@sesheta
Copy link
Member

sesheta commented Jan 12, 2022

@fridex: Closed this PR.

In response to this:

/close

Closing, adjusted in #1597

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt]Review openapi schema
2 participants