Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger-client and documentation #998

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jan 10, 2022

Related Issues and Dependencies

Related: thoth-station/user-api#1590

This introduces a breaking change

  • No

Description

Update the client respecting OpenAPI schema.

@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 10, 2022
@fridex fridex marked this pull request as draft January 10, 2022 19:36
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@harshad16 harshad16 removed their request for review January 11, 2022 14:00
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 11, 2022
@fridex fridex force-pushed the update-swagger-client branch 4 times, most recently from 5100f19 to c52bf7a Compare January 12, 2022 18:57
@fridex fridex marked this pull request as ready for review January 12, 2022 20:46
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022
@fridex fridex force-pushed the update-swagger-client branch 5 times, most recently from 49d41a8 to dae9276 Compare January 13, 2022 16:06
@fridex
Copy link
Contributor Author

fridex commented Jan 13, 2022

/approve

This version is needed to properly consume all the data on API endpoints.

@sesheta
Copy link
Member

sesheta commented Jan 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@fridex
Copy link
Contributor Author

fridex commented Jan 13, 2022

All green.

@fridex fridex merged commit 12be1b9 into thoth-station:master Jan 13, 2022
@fridex fridex deleted the update-swagger-client branch January 13, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants