Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THOTH_CEPH_PREFIX should use the same mechanims as other env vars #2717

Open
1 task
VannTen opened this issue Sep 23, 2022 · 2 comments
Open
1 task

THOTH_CEPH_PREFIX should use the same mechanims as other env vars #2717

VannTen opened this issue Sep 23, 2022 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@VannTen
Copy link
Member

VannTen commented Sep 23, 2022

Problem statement

As a Thoth developer, I would like to have a single place defining ceph prefix
in CephStore, using and environment variable.
(Either in storages code itself, or in other components using storage)

Proposal description

Use same logic that for bucket and other (see thoth/storages/ceph.py).
I think this needs some work on adapting storages codes which set the prefix
itself for "subprefixing".

Introducing a global prefix / sub prefix might be something to think about

Additional context

Relevant: #2700

Acceptance Criteria

  • Only CephStore use THOTH_CEPH_PREFIX in storages, and CephStore().prefix == os.getenv('THOTH_CEPH_PREFIX')

/kind feature
/sig stack-guidance
@VannTen VannTen added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 23, 2022
@sesheta sesheta added the sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. label Sep 23, 2022
VannTen added a commit to VannTen/document-sync-job that referenced this issue Sep 23, 2022
@VannTen
Workaround for thoth-station/storages#2717
fa345fd
@VannTen
Copy link
Member Author

VannTen commented Sep 26, 2022

Same remarks for THOTH_DEPLOYMENT_NAME

VannTen added a commit to VannTen/document-sync-job that referenced this issue Sep 26, 2022
@VannTen
Workaround for thoth-station/storages#2717
96c77b0
VannTen added a commit to VannTen/document-sync-job that referenced this issue Sep 29, 2022
@VannTen
Workaround for thoth-station/storages#2717
2a387e6
VannTen added a commit to VannTen/document-sync-job that referenced this issue Sep 30, 2022
@VannTen
Boto3 s3 client configuration and credentials
510b013 
We reuse the CephStore object from thoth-storages. However, it is
incomplete and we need to check some environment variables ourselves.
See thoth-station/storages#2717
VannTen added a commit to VannTen/document-sync-job that referenced this issue Oct 7, 2022
@VannTen
Boto3 s3 client configuration and credentials
405e73a 
We reuse the CephStore object from thoth-storages. However, it is
incomplete and we need to check some environment variables ourselves.
See thoth-station/storages#2717
@VannTen
Copy link
Member Author

VannTen commented Nov 16, 2022

/priority important-longterm

@sesheta sesheta added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VannTen @sesheta