Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bash, always #236

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Use bash, always #236

merged 1 commit into from
Apr 25, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Mar 16, 2022

This introduces a breaking change

  • No

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2022
@sesheta
Copy link
Member

sesheta commented Mar 16, 2022

@fridex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit 23d184d link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

harshad16
harshad16 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Member

sesheta commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit adae10a into thoth-station:master Apr 25, 2022
@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@pacospace pacospace Awaiting requested review from pacospace

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @harshad16