Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spike] Decide on how to package and deploy the pipeline manifests #10

Closed
codificat opened this issue Sep 14, 2022 · 10 comments · Fixed by thoth-station/meteor-operator#108 or #29
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps.

Comments

@codificat
Copy link
Member

codificat commented Sep 14, 2022

At the time of this writing, the pipeline manifests for the CNBi feature implemented via the Meteor operator are added in the operator's repo under the hack/ directory and deployed via the Makefile.

The pipelines should eventually be properly packaged and deployed.

Options:

  • Use the helm-charts repository as the source for all pipeline manifests, and deploy them via:
    • helm
    • KfDef
    • ArgoCD
  • Have the operator deploy the manifests itself
  • Keep the manifests in the operator repo, deploy them via:
    • KfDef
    • ArgoCD
@codificat
Copy link
Member Author

/sig devsecops
/kind feature
/priority important-longterm

@sesheta
Copy link
Member

sesheta commented Sep 14, 2022

@codificat: The label(s) sig/devsecops, kind/feature, priority/important-longterm cannot be applied, because the repository doesn't have them.

In response to this:

/sig devsecops
/kind feature
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codificat
Copy link
Member Author

Trying again:
/sig devsecops
/kind feature
/priority important-longterm

@sesheta sesheta added sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 20, 2022
@codificat
Copy link
Member Author

/wg cnbi

@codificat codificat mentioned this issue Sep 27, 2022
7 tasks
@VannTen
Copy link
Member

VannTen commented Oct 4, 2022

* Have the operator deploy the manifests itself

Many k8s operators appears to do that, but in my opinion they should not. The Roles needed for installing and running are not the same.

* Use the [helm-charts repository](https://github.com/thoth-station/helm-charts/) as the source for all pipeline manifests, and deploy them via:
* Keep the manifests in the [operator repo](https://github.com/AICoE/meteor-operator), deploy them via:

Is is a good resume to say that those two options bog down to bundle the pipelines with the operator, or separately ?
If that's the case, I think the decision depends on whether we see the operator as extendable or not.
=> Does each Pipeline constitutes a plugin to make the operator able to handle a particular CR type (PackageList/GitRepo/whatever) ? Or do we have a bounded set of types (and hence of handlers).

Note that we could combine the two.

@VannTen
Copy link
Member

VannTen commented Oct 6, 2022

Note from the meeting yesterday: might have some troubles using KfDef since it's using kustomize which is less powerful (if simpler) than something like helm (=> array merging in yaml)

@harshad16
Copy link
Member

Based on the previous discussions in CNBI meetings.
The consensus of having the pipelines with cnbi operator was picked up.
with #29 and #108 this would be implemented.

@codificat
Copy link
Member Author

/reopen
pending the merge of thoth-station/meteor-operator#108

@sesheta
Copy link
Member

sesheta commented Nov 10, 2022

@codificat: Reopened this issue.

In response to this:

/reopen
pending the merge of thoth-station/meteor-operator#108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta reopened this Nov 10, 2022
@harshad16
Copy link
Member

Removed the revised-size as the issue is yet to be marked done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps.
Projects
Status: Done
Status: Done
4 participants