Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to ignore local dependencies #412

Open
5 tasks
Tracked by #401
codificat opened this issue May 23, 2022 · 3 comments
Open
5 tasks
Tracked by #401

An option to ignore local dependencies #412

codificat opened this issue May 23, 2022 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.

Comments

@codificat
Copy link
Member

codificat commented May 23, 2022

Problem statement

As a Data Scientist looking to incorporate Thoth's stack guidance service to my existing project,
I find that my current Pipfile is not supported by Thoth because it contains a package reference to a local path, e.g.

src = {path = "./src/boilerplate"}

(or an equivalent content in requirements.txt, e.g. ./src/boilerplate)

that I use to share code between my various notebooks.

This prevents me from using Thoth to get advise on my software stack.

High-level Goals

To provide an option in the advise service that allows the user to state their desire to ignore references to local path packages.

Proposal description

The proposal would allow users of the advise service to specify an option to ignore the presence of local modules referenced as dependencies.

It should be very clear in the option's help and associated documentation:

  • what are the consequences of using that option
  • what alternatives exist, and why they are better
  • which use cases this option is meant to address

Alternatives

Leave it as is and do not accept path-based dependencies.

Additional context

Documentation about this would be closely related to / part of #411.

This feature request was discussed in the Let's talk Thoth tech... meeting on 2022-05-19 (meeting notes / recording).

About where does this request comes from / how much demand there would be, some anecdotal references:

Acceptance Criteria

  • an option to skip local packages during an advise exists
  • the documentation of the option clearly covers:
    • which use cases this option is meant to cover
    • what alternatives exist to using that option
    • pros and cons of the option and the alternatives
@codificat codificat added the kind/feature Categorizes issue or PR as related to a new feature. label May 23, 2022
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label May 23, 2022
@sesheta
Copy link
Member

sesheta commented May 23, 2022

@codificat: This issue is currently awaiting triage.
If a refinement session determines this is a relevant issue, it will accept the issue by applying the
triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@goern
Copy link
Member

goern commented Jul 20, 2022

/sig user-experience
/priority backlog

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig labels Jul 20, 2022
@codificat
Copy link
Member Author

/wg cnbi

@sesheta sesheta added the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.
Projects
Status: 📋 Backlog
Status: 🆕 New
Development

No branches or pull requests

3 participants