Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3pt] Document Thoth's requirement for dependencies to be in an index #411

Open
6 tasks
Tracked by #401
codificat opened this issue May 19, 2022 · 8 comments
Open
6 tasks
Tracked by #401
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.

Comments

@codificat
Copy link
Member

codificat commented May 19, 2022

Problem statement

As a Thoth user, I am frustrated because Thoth can not provide advise about my application software stack, because my Pipfile references modules that are not hosted in a package index (local modules, file / git references).

For example:

And if I run thamos advise and my Pipfile contains an editable install:

$ thamos advise
2022-05-19 13:50:37,067 [163181] WARNING  thamos: Development dependencies will not be considered during the resolution process - see https://thoth-station.ninja/j/no_dev
2022-05-19 13:50:37,067 [163181] INFO     thamos.lib: Using Pipenv files to manage dependencies located in '/home/pep/github/os-climate/aicoe-osc-demo'
2022-05-19 13:50:37,067 [163181] INFO     thamos.lib: Submitting Pipfile.lock as a base for user's stack scoring - see https://thoth-station.ninja/j/user_stack
2022-05-19 13:50:37,068 [163181] ERROR    thamos: Failed to load Pipfile (path: /home/pep/github/os-climate/aicoe-osc-demo/Pipfile: Package 'src' is editable local project instead of a package from a package index

and it is unclear to me why this is an ERROR and how to fix it.

High-level Goals

Documentation exists, clearly reachable within the Thoth documentation, that explains:

  • why this is happening
  • what are the alternatives and their implications
  • how should I proceed so that Thoth can provide advice

Proposal description

Alternatives

Additional context

A blog post was published one year ago about this topic: https://developers.redhat.com/articles/2021/05/26/can-we-consider-editable-bad-practice

However, this is not part of Thoth's documentation.

Acceptance Criteria

Documentation in the Thoth website covers:

  • the requirements that my dependency specifications must meet
  • the reasoning behind these requirements
  • alternative options and their consequences
  • clear steps to help me meet the requirements
  • pointers and references to learn more about it

And based on that documentation:

  • create a follow-up issue so that entry points that fail due to unmet requirements provide links to the documentation about them
@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels May 19, 2022
@codificat
Copy link
Member Author

/sig user-experience
/triage accepted
/priority important-soon

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels May 19, 2022
@codificat
Copy link
Member Author

Given that the content of the documentation is heavily tied to the guidance service, this is
/sig stack-guidance
more than
/remove-sig user-experience

@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. and removed sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. labels May 23, 2022
@mayaCostantini mayaCostantini changed the title Document Thoth's requirement for dependencies to be in an index [3pt] Document Thoth's requirement for dependencies to be in an index May 30, 2022
@codificat
Copy link
Member Author

/assign

@codificat
Copy link
Member Author

A (relatively) related request is thoth-station/adviser#2275.

@mayaCostantini mayaCostantini added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 27, 2022
@sesheta
Copy link
Member

sesheta commented Sep 25, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2022
@codificat
Copy link
Member Author

/wg cnbi

@sesheta sesheta added the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Sep 27, 2022
@codificat
Copy link
Member Author

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2022
@codificat
Copy link
Member Author

This is delayed waiting for input from the alternative approaches and how they apply to a real-life use case, e.g. thoth-station/opendatahub-cnbi#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.
Projects
Status: Blocked
Status: 🔖 Ready
Development

No branches or pull requests

3 participants