Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3pt] Move away from setuptools and use pyproject.toml instead #360

Open
4 tasks
Tracked by #1144
fridex opened this issue Dec 6, 2021 · 13 comments
Open
4 tasks
Tracked by #1144

[3pt] Move away from setuptools and use pyproject.toml instead #360

fridex opened this issue Dec 6, 2021 · 13 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Dec 6, 2021 •
edited by harshad16
Loading

Is your feature request related to a problem? Please describe.

As Thoth, I would like to get rid of setuptools and start using pyproject.toml-based projects as that's how Python community is shifting.

Acceptance criteria

  • Configure setuptools bit in pyproject.toml.
  • Set only release bits in setup.py
  • start with the repo https://github.com/thoth-station/thamos
  • Replicate in All repositories currently using setup.py and pyproject.toml
@fridex fridex added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Dec 6, 2021
@codificat
Copy link
Member

/assign @fridex
to refine a bit more, especially by providing a list of acceptance criteria referencing all the parts/components that would be impacted

@codificat
Copy link
Member

/triage needs-information

@sesheta sesheta added the triage/needs-information Indicates an issue needs more information in order to work on it. label Dec 22, 2021
@goern goern removed the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Feb 16, 2022
@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2022
@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 16, 2022
@sesheta
Copy link
Member

sesheta commented Jul 16, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 16, 2022
@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels Jul 16, 2022
@mayaCostantini
Copy link
Contributor

/remove-lifecycle rotten
/sig stack-guidance
/priority backlog

@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-sig labels Jul 16, 2022
@mayaCostantini mayaCostantini removed triage/needs-information Indicates an issue needs more information in order to work on it. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Jul 16, 2022
@mayaCostantini
Copy link
Contributor

/good-first-issue

@sesheta
Copy link
Member

sesheta commented Aug 8, 2022

@mayaCostantini:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 8, 2022
@mayaCostantini
Copy link
Contributor

See https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

@mayaCostantini
Copy link
Contributor

/triage accepted
/priority important-soon

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 8, 2022
@mayaCostantini mayaCostantini changed the title Move away from setuptools and use pyproject.toml instead [3pt] Move away from setuptools and use pyproject.toml instead Aug 8, 2022
@mayaCostantini mayaCostantini removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 8, 2022
@VannTen
Copy link
Member

VannTen commented Aug 18, 2022 •
edited
Loading

this might help: https://dephell.readthedocs.io/

This was referenced Sep 21, 2022
Closed
Open
@VannTen
Copy link
Member

VannTen commented Sep 21, 2022 •
edited
Loading

I think we should turn this into a tracker issue, and open an issue on each of
our repositories we care about.
The individual tasks are not hard, but it's take time. This is typically the
type of stuff which could be done in hacktoberfest, but for that we need to
break it up into manageable chunks, and per repo seems the easiest.

I can script the issue creation without too much trouble I think.

@goern

@thoth-station thoth-station deleted a comment from sesheta Sep 21, 2022
@thoth-station thoth-station deleted a comment from sesheta Sep 21, 2022
@thoth-station thoth-station deleted a comment from sesheta Sep 21, 2022
@thoth-station thoth-station deleted a comment from sesheta Sep 21, 2022
@goern
Copy link
Member

goern commented Sep 22, 2022

I can script the issue creation without too much trouble I think.
@goern

please go ahead :)

This was referenced Sep 26, 2022
Open
Open
Open
Open
Closed
Closed
Open
Closed
Open
Open
Closed
Closed
@VannTen
Copy link
Member

VannTen commented Sep 26, 2022 •
edited
Loading

For now I put repos with a setup.py and no pyproject.toml. There is other (both
presents for example), but that should the easiest ones.

If someone can add this to the issues desc...

@VannTen
Copy link
Member

VannTen commented Sep 28, 2022

Might be relevant (possible way to script the translation):
https://stackoverflow.com/a/73830494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@goern @codificat @fridex @VannTen @sesheta @mayaCostantini