Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #2358

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix a typo #2358

merged 1 commit into from
Aug 1, 2022

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jul 6, 2022

The plot and the text following this sentence clearly express it's 25000
rather than 2500

The plot and the text following this sentence clearly express it's 25000
rather than 2500
@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@sesheta
Copy link
Member

sesheta commented Jul 6, 2022

Hi @VannTen. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codificat
Copy link
Member

Oh, it's only a zero... it's nothing, right? 😃

Thanks for the fix!

/approve
/ok-to-test
(although I bet tests will fail due to #2356 - and if so this will have to be merged manually)

@sesheta
Copy link
Member

sesheta commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2022
@sesheta
Copy link
Member

sesheta commented Jul 7, 2022

@VannTen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit a46420d link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harshad16 harshad16 merged commit 37557b8 into thoth-station:master Aug 1, 2022
@VannTen VannTen deleted the fix_typos branch September 20, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants