Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GitHub issue templates #2312

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

The trigger for this is that the needs-triage label is no longer in widespread use (see thoth-station/thoth-application#2359)
but the templates are still adding it to new issues in this repo (see e.g. #2308 from yesterday).

This introduces a breaking change

  • No

This Pull Request implements

Update the GitHub issue and PR templates taking the current content from the template repo

Taking the current content from the template repo

Signed-off-by: Pep Turró Mauri <pep@redhat.com>
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2022
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! 💯

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2022
@goern
Copy link
Member

goern commented Mar 22, 2022

/approve

@sesheta
Copy link
Member

sesheta commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codificat
Copy link
Member Author

/test build-check

@codificat
Copy link
Member Author

/override aicoe-ci/build-check

@sesheta
Copy link
Member

sesheta commented Mar 23, 2022

@codificat: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-commit
  • /test thoth-pytest-py38

Use /test all to run all jobs.

In response to this:

/test build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshad16
Copy link
Member

webhooks are degraded: https://www.githubstatus.com/
CI isnt getting the webhook to get triggered

@harshad16
Copy link
Member

/retest

2 similar comments
@goern
Copy link
Member

goern commented Mar 24, 2022

/retest

@codificat
Copy link
Member Author

/retest

@sesheta sesheta merged commit 262c4d8 into thoth-station:master Mar 28, 2022
@codificat codificat deleted the update-templates branch March 28, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants