Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent inlining big functions #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfonsogarciacaro
Copy link
Contributor

Follow up of #29. This prevents inlining big functions by putting the bulk of the fetch code in non-inlined __tryFetchAs function that receives the data and response Type arguments. tryFetchAs is still inlined but now the only thing it does is generating the types with typeof and passing them to __tryFetchAs.

Note: it should be possible to mark __tryFetchAs with internal so it's not visible to consumers. But sometimes I get errors from the F# compiler when inlined functions call private/internal functions so for now I'm just prefixing it with __.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant