Use ptr::slice_from_raw_parts to fix UB in Miri
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Aug 29, 2022
New lint: Raw slice pointer cast Adds a lint to check for a raw slice being created and cast back to a pointer, suggesting `ptr::slice_from_raw_parts`, to identify UB such as thomcc/rust-typed-arena#54. ``` changelog: [`cast_slice_from_raw_parts`]: Add lint to check for `slice::from_raw_parts(.., ..) as *const _` ```
thomcc
reviewed
Jan 9, 2023
| let start = chunks.current.as_mut_ptr().offset(next_item_index as isize); | ||
| let start_uninit = start as *mut MaybeUninit<T>; | ||
| slice::from_raw_parts_mut(start_uninit, len) as *mut _ | ||
| std::ptr::slice_from_raw_parts_mut(start_uninit, len) |
There was a problem hiding this comment.
This should not use std directly, since this crate supports no_std.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52 by using
ptr::slice_from_raw_partsinstead of creating a raw slice and casting to a pointer