Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang.org/x/tools #22

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

clfs
Copy link
Contributor

@clfs clfs commented Mar 17, 2023

I was having issues running fzgen on golang.org/x/text:

calvin@mbp text % fzgen ./...
2023/03/17 16:11:50 internal error: package "sort" without types was imported from "golang.org/x/text/internal/tag"

Bumping golang.org/x/tools to latest, then rebuilding fzgen, fixed this issue:

calvin@mbp text % ../fzgen/cmd/fzgen/fzgen ./...
fzgen: created cases/autofuzz_test.go
fzgen: created cmd/gotext/autofuzz_test.go
fzgen: skipping golang.org/x/text/cmd/gotext/examples/extract_http/pkg: unsupported parameters: Generize takes net/http.ResponseWriter
fzgen: created collate/autofuzz_test.go
fzgen: created collate/build/autofuzz_test.go
fzgen: created collate/tools/colcmp/autofuzz_test.go
fzgen: created currency/autofuzz_test.go
fzgen: created encoding/autofuzz_test.go
fzgen: created encoding/charmap/autofuzz_test.go
fzgen: created encoding/htmlindex/autofuzz_test.go
fzgen: created encoding/ianaindex/autofuzz_test.go
fzgen: created encoding/internal/autofuzz_test.go
fzgen: skipping golang.org/x/text/encoding/internal/enctest: unsupported parameters: Benchmark takes golang.org/x/text/encoding.Encoding
fzgen: created encoding/unicode/autofuzz_test.go
fzgen: created encoding/unicode/utf32/autofuzz_test.go
fzgen: created feature/plural/autofuzz_test.go
fzgen: created internal/autofuzz_test.go
fzgen: created internal/catmsg/autofuzz_test.go
fzgen: created internal/cldrtree/autofuzz_test.go
fzgen: created internal/colltab/autofuzz_test.go
fzgen: created internal/export/idna/autofuzz_test.go
fzgen: created internal/format/autofuzz_test.go
fzgen: created internal/gen/autofuzz_test.go
fzgen: skipping golang.org/x/text/internal/gen/bitfield: unsupported parameters: Gen takes interface{}
fzgen: created internal/language/autofuzz_test.go
fzgen: created internal/language/compact/autofuzz_test.go
fzgen: created internal/number/autofuzz_test.go
fzgen: created internal/stringset/autofuzz_test.go
fzgen: created internal/tag/autofuzz_test.go
fzgen: created internal/testtext/autofuzz_test.go
fzgen: created internal/triegen/autofuzz_test.go
fzgen: created internal/ucd/autofuzz_test.go
fzgen: created language/autofuzz_test.go
fzgen: created language/display/autofuzz_test.go
fzgen: created message/autofuzz_test.go
fzgen: created message/catalog/autofuzz_test.go
fzgen: created message/pipeline/autofuzz_test.go
fzgen: created number/autofuzz_test.go
fzgen: created runes/autofuzz_test.go
fzgen: created search/autofuzz_test.go
fzgen: created secure/bidirule/autofuzz_test.go
fzgen: created secure/precis/autofuzz_test.go
fzgen: created transform/autofuzz_test.go
fzgen: created unicode/bidi/autofuzz_test.go
fzgen: created unicode/cldr/autofuzz_test.go
fzgen: created unicode/norm/autofuzz_test.go
fzgen: created unicode/rangetable/autofuzz_test.go
fzgen: created unicode/runenames/autofuzz_test.go
fzgen: created width/autofuzz_test.go
fzgen: created 46 files

FYI, an old issue mentions a similar error in Tailscale: #3

@thepudds
Copy link
Owner

Hi @clfs, thanks so much for the PR!

Sorry, this has been on my list to do.

Thanks again, and please let me know if you have any further feedback.

@thepudds thepudds merged commit 7a5551f into thepudds:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants