Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen: make "." the default constructor regex pattern and improve emitted comments #16

Merged
merged 6 commits into from
Jan 3, 2022
Merged

gen: make "." the default constructor regex pattern and improve emitted comments #16

merged 6 commits into from
Jan 3, 2022

Conversation

thepudds
Copy link
Owner

@thepudds thepudds commented Jan 3, 2022

  • A wider set of candidate constructors are examined by default.
    • Previously, the regexp '^New' was the default, but now '.' is the default -ctor regexp.
    • Hopefully people will only rarely use the -ctor flag now.
  • We no longer emit a comment suggest running goimports given we have been doing the equivalent via golang.org/x/tools/imports API. (Fixes remove emitted comment about goimports #4).
  • Other smaller improvements to emitted comments or skip messages.

@thepudds thepudds merged commit 6cb5a43 into main Jan 3, 2022
@thepudds thepudds mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove emitted comment about goimports
1 participant
@thepudds