Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix including interval in response of device authorization request #1410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hafezdivandari
Copy link

I'm implementing device authorization flow on Laravel Passport, but when I call $grant->setIntervalVisibility(true) the response still doesn't include interval. On the response you are excluding interval when it's set to default 5. Although the server may use the default interval value, we still want to include the internal on the response.

PS: Also a typo has been fixed on DeviceCodeRepositoryInterface, $deviceCodeEntity -> $deviceCode

@Sephster
Copy link
Member

Sephster commented Jul 2, 2024

@hafezdivandari apologies I've not forgotten about this. My partner is sick just now and my son has a sickness bug so I have little time but will get to it as soon as she is better. Apologies for the delay. Just wanted to give you an update

@hafezdivandari
Copy link
Author

@Sephster No worries at all! Take all the time you need. I hope your family feels better soon.

@hafezdivandari
Copy link
Author

Hi @Sephster, hope you’re doing well. Any progress on the PRs related to Laravel Passport? I’ve listed them all here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants