Audit logs for creation and updates to verification requests #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchrisadams
commented
May 3, 2024
| @@ -1448,6 +1450,25 @@ def send_approval_email( | |||
| template_html="emails/verification_request_approved.html", | |||
| ) | |||
|
|
|||
| def log_message( | |||
There was a problem hiding this comment.
This convenience method is intended to make it much easier to log changes we make that might not otherwise be made in the admin
mrchrisadams
commented
May 3, 2024
| @@ -279,6 +283,26 @@ class Steps(Enum): | |||
| Steps.PREVIEW.value: "provider_registration/preview.html", | |||
| } | |||
|
|
|||
| def log_creation( | |||
There was a problem hiding this comment.
This allows us to log various events to the django log_entries table, from outside the admin.
It's used outside approve() method for a provider request because access to the user in a given request is required.
If we created a "robot" user, we coud use this same approach for logging automated updates too, but that's outside the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces use of the django log entry feature to provide a more accessible audit log when staff or users are working with verification requests.