Skip to content

Commit

Permalink
Make the detail view of provider request always accessible for admins
Browse files Browse the repository at this point in the history
  • Loading branch information
tortila authored and mrchrisadams committed Jul 24, 2023
1 parent 3a32f6c commit 19e37f2
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
15 changes: 15 additions & 0 deletions apps/accounts/tests/test_provider_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,21 @@ def test_detail_view_accessible_by_creator(client):
assert response.context_data["providerrequest"] == pr


@pytest.mark.django_db
@override_flag("provider_request", active=True)
def test_detail_view_accessible_by_admin(client, greenweb_staff_user):
# given: provider request exists
pr = ProviderRequestFactory.create()

# when: accessing its detail view by greenweb_staff_user
client.force_login(greenweb_staff_user)
response = client.get(urls.reverse("provider_request_detail", args=[str(pr.id)]))

# then: page for the correct provider request is rendered
assert response.status_code == 200
assert response.context_data["providerrequest"] == pr


@pytest.mark.django_db
@override_flag("provider_request", active=True)
def test_detail_view_forbidden_for_others(client, user):
Expand Down
6 changes: 6 additions & 0 deletions apps/accounts/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,12 @@ class ProviderRequestDetailView(LoginRequiredMixin, WaffleFlagMixin, DetailView)
model = ProviderRequest

def get_queryset(self) -> "QuerySet[ProviderRequest]":
"""
Admins can retrieve any ProviderRequest object,
regular users can only retrieve objects that they created.
"""
if self.request.user.is_admin:
return ProviderRequest.objects.all()
return ProviderRequest.objects.filter(created_by=self.request.user)


Expand Down

0 comments on commit 19e37f2

Please sign in to comment.