Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems to support testing Puppet 8 #143

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 29, 2023

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Sep 29, 2023

Needs to drop Puppet 6: #144

@ekohl ekohl force-pushed the update-gems branch 2 times, most recently from 806fdbc to 6c30fb0 Compare September 29, 2023 14:20
@ekohl
Copy link
Member Author

ekohl commented Oct 6, 2023

This fails because it uses Puppet 8 in the CentOS 9 acceptance tests. I don't understand why only that one does that, while the environment should be the same for all. I'm not even sure why we have Puppet at all in there.

Needs further investigation.

@ekohl
Copy link
Member Author

ekohl commented Oct 9, 2023

Just writing down the research I did: we pull in puppetlabs_spec_helper for fixture handling, which pulls in puppet-syntax, which pulls in puppet. Somehow bundler thinks it can pull in puppet 8 but then later finds out it can't use that with Ruby 3.0. In gha-puppet the Ruby version in acceptance tests is updated to 3.2, so that should work.

Ideally we would have a separate gem which can pull in the fixtures. puppetlabs_spec_helper would pull in that gem as well. I did a bit of poking at that and will see if I can get something off the ground for the long term.

@ekohl ekohl merged commit d21aaee into theforeman:master Nov 3, 2023
11 checks passed
@ekohl ekohl deleted the update-gems branch November 3, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant