Fixes #29210 - support el8 #160
Conversation
|
@ekohl I noticed el7 tests were missing here so I added those as well. If that's intentional, please let me know why and I'll remove them. Thanks! |
|
See bf846e4 / #151 (comment) for the EL7 history. It may work to use the CentOS 7.6 container image instead of the latest 7. |
|
@wbclark Also, needs a rebase. |
wbclark
changed the title
wbclark
force-pushed
the
el8
branch
2 times, most recently
from
d95cc0c
to
60fe199
Compare
.sync.yml
Outdated
| @@ -5,6 +5,8 @@ | |||
| .travis.yml: | |||
| beaker_sets: | |||
| - centos6-64 | |||
| - centos7-64 | |||
There was a problem hiding this comment.
This will fail: theforeman/foreman-installer-modulesync#121 should have the workaround.
spec/setup_acceptance_node.pp
Outdated
| @@ -0,0 +1,8 @@ | |||
| if $facts['os']['family'] == 'RedHat' { | |||
There was a problem hiding this comment.
As stated elsewhere: I'd like to avoid this if possible.
There was a problem hiding this comment.
Will update this once I see how https://github.com/theforeman/puppet-dhcp/pull/167/files#diff-354f30a63fb0907d4ad57269548329e3R38 works out
wbclark
force-pushed
the
el8
branch
2 times, most recently
from
caaf195
to
756e6e2
Compare
|
Due to docker/for-linux#835 , services are failing to start in the Travis test environment, causing test failures. However all tests are succeeding when I run them locally on a vagrant_libvirt el8 VM. @ehelms what are your thoughts on adding el8 support without adding tests to the travis config, similarly to what we previously did for this project on el7? |
|
I am OK with this, as a fix for the time after 2.1 branching seems to be in the works. |
|
merged, thanks @wbclark! |
No description provided.