Make zone update_policy_rules more generic #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damluk
force-pushed
the
feature/zone-options/update-policy
branch
from
fbca0c3
to
bd721f8
Compare
|
I decided to deprecate the parameter instead of breaking directly. |
damluk
force-pushed
the
feature/zone-options/update-policy
branch
3 times, most recently
from
61d4c51
to
26ac50e
Compare
damluk
force-pushed
the
feature/zone-options/update-policy
branch
from
26ac50e
to
bf4c97f
Compare
ekohl
reviewed
Apr 9, 2020
damluk
force-pushed
the
feature/zone-options/update-policy
branch
from
bf4c97f
to
68b949f
Compare
damluk
force-pushed
the
feature/zone-options/update-policy
branch
from
68b949f
to
11b74d9
Compare
damluk
force-pushed
the
feature/zone-options/update-policy
branch
from
11b74d9
to
d2c5a35
Compare
ekohl
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #156. I submit it separately from the other zone options I want to introduce, because this PR might be a breaking change for some installations.