Add support for managing sysconfig settings #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian and RedHat allow setting startup options and other settings via a sysconfig/default file (/etc/default/bind9 under Debian and /etc/sysconfig/named under RedHat). FreeBSD/DragonFly and ArchLinux don't have a direct equivalent. This change allows managing sysconfig/default settings under Debian and RedHat. It is especially useful for setting startup options like `-4` to disable IPv6 support in named, or setting the debug level with `-d`. The change adds a few specific `$dns::sysconfig_*` parameters to model the default behaviour under Debian and RedHat, as well as a `$dns::sysconfig_additional_settings` hash parameter that allows setting arbitrary key-value pairs in the sysconfig file. For FreeBSD/DragonFly and ArchLinux these parameters are all set to undef and not used anywhere since they feature is no directly equivalent sysconfig setup. This change also adds basic spec tests for Debian, including tests for the sysconfig support introduced here.
ekohl
reviewed
May 21, 2019
|
@ekohl It seems that Ubuntu 18.04 (and probably Debians as well) still uses |
|
It seems I was wrong. Both Ubuntu 16.04 and 18.04 provide systemd unit files for bind9, but both read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian and RedHat allow setting startup options and other settings via a
sysconfig/default file (/etc/default/bind9 under Debian and
/etc/sysconfig/named under RedHat). FreeBSD/DragonFly and ArchLinux
don't have a direct equivalent.
This change allows managing sysconfig/default settings under Debian and
RedHat. It is especially useful for setting startup options like
-4todisable IPv6 support in named, or setting the debug level with
-d. Thechange adds a few specific
$dns::sysconfig_*parameters to model thedefault behaviour under Debian and RedHat, as well as a
$dns::sysconfig_additional_settingshash parameter that allows settingarbitrary key-value pairs in the sysconfig file.
For FreeBSD/DragonFly and ArchLinux these parameters are all set to
undef and not used anywhere since they feature is no directly equivalent
sysconfig setup.
This change also adds basic spec tests for Debian, including tests for
the sysconfig support introduced here.