Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36535 - pin fog-vsphere to 3.6.0 #9755

Closed
wants to merge 1 commit into from
Closed

Fixes #36535 - pin fog-vsphere to 3.6.0 #9755

wants to merge 1 commit into from

Conversation

stejskalleos
Copy link
Contributor

fog-vsphere 3.6.1 [0] is causing failures in the
test/controllers/api/v2/hosts_controller_test.

The temporary fix is to pin the version to 3.6.0.

[0] fog/fog-vsphere#285

@stejskalleos stejskalleos requested a review from a team as a code owner June 27, 2023 08:25
@theforeman-bot
Copy link
Member

Issues: #36535

1 similar comment
@theforeman-bot
Copy link
Member

Issues: #36535

@stejskalleos
Copy link
Contributor Author

@chris1984

This was referenced Jun 27, 2023
Merged
Closed
@stejskalleos stejskalleos changed the title Fixes #36535 - Ping fog-vsphere to 3.6.0 Fixes #36535 - ping fog-vsphere to 3.6.0 Jun 27, 2023
@stejskalleos stejskalleos changed the title Fixes #36535 - ping fog-vsphere to 3.6.0 Fixes #36535 - pin fog-vsphere to 3.6.0 Jun 27, 2023
chris1984
chris1984 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, working on fixing the gem today

@ofedoren
Copy link
Member

Should we merge this or we're waiting for fog-vsphere to stabilize? I'd like to unblock the tests...

@chris1984
Copy link
Member

chris1984 commented Jun 29, 2023 •
edited
Loading

@ofedoren @stejskalleos I just pushed the correct size of fog-vsphere 3.6.2 to rubygems, so can you try to pull in the latest unpinned and see if it works. I yanked the bad one and will open up a packaging pr to bring in 3.6.2 to the repos.

ekohl
ekohl reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris1984 any effort tracking the regression?

bundler.d/vmware.rb Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Jun 29, 2023

Apologies, I somehow didn't see your update about 3.6.2.

@stejskalleos
Fixes #36535 - Pin fog-vsphere to 3.6.0
822cac9 
fog-vsphere 3.6.1 [0] is causing failures in the
test/controllers/api/v2/hosts_controller_test.

The temporary fix is to pin the version to 3.6.0.

[0] fog/fog-vsphere#285
@stejskalleos
Copy link
Contributor Author

Updated to gem 'fog-vsphere', '~> 3.6', '!= 3.6.1'

@evgeni
Copy link
Member

evgeni commented Jun 30, 2023

Do we even need this PR now that 3.6.1 was yanked?

@ekohl
Copy link
Member

ekohl commented Jun 30, 2023

That's a fair question. I'd say not.

@ekohl ekohl closed this Jun 30, 2023
@evgeni
Copy link
Member

evgeni commented Jun 30, 2023

And to do the paperwork, the CI for this run used 3.6.2 (see https://ci.theforeman.org/job/foreman-pr-integration-test/1330/artifact/Gemfile.lock/*view*/ and https://ci.theforeman.org/job/foreman-pr-unit-test/1332/artifact/Gemfile.lock/*view*/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stejskalleos @theforeman-bot @ofedoren @chris1984 @ekohl @evgeni