-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make installing on Windows work #5280
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.4 #5280 +/- ##
=========================================
Coverage 63.37% 63.37%
Complexity 1394 1394
=========================================
Files 195 195
Lines 4120 4120
=========================================
Hits 2611 2611
Misses 1509 1509
Continue to review full report at Codecov.
|
Maybe we should change this one too, it's probably not a problem but it should be better. |
This was never a problem for me on windows, but done. |
Codecov Report
@@ Coverage Diff @@
## 1.4 #5280 +/- ##
=========================================
Coverage 63.37% 63.37%
Complexity 1394 1394
=========================================
Files 195 195
Lines 4120 4120
=========================================
Hits 2611 2611
Misses 1509 1509
Continue to review full report at Codecov.
|
As Windows uses
\r\n
as new-line, renaming the seeders does not work and thus, installing fails when using Laravel 8 on Windows.