Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installing on Windows work #5280

Merged
merged 6 commits into from
May 1, 2021
Merged

Make installing on Windows work #5280

merged 6 commits into from
May 1, 2021

Conversation

emptynick
Copy link
Collaborator

As Windows uses \r\n as new-line, renaming the seeders does not work and thus, installing fails when using Laravel 8 on Windows.

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #5280 (34e9ff2) into 1.4 (3c2d314) will not change coverage.
The diff coverage is 33.33%.

❗ Current head 34e9ff2 differs from pull request most recent head 9bb1794. Consider uploading reports for the commit 9bb1794 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5280   +/-   ##
=========================================
  Coverage     63.37%   63.37%           
  Complexity     1394     1394           
=========================================
  Files           195      195           
  Lines          4120     4120           
=========================================
  Hits           2611     2611           
  Misses         1509     1509           
Impacted Files Coverage Δ Complexity Δ
src/Commands/InstallCommand.php 71.42% <33.33%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2d314...9bb1794. Read the comment docs.

@MrCrayon
Copy link
Collaborator

MrCrayon commented Apr 1, 2021

Maybe we should change this one too, it's probably not a problem but it should be better.

https://github.com/the-control-group/voyager/blob/0d509a021fbc95654c699c74b6c9d98e1b1c2bdb/src/Commands/InstallCommand.php#L120

@emptynick
Copy link
Collaborator Author

This was never a problem for me on windows, but done.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #5280 (b6a2911) into 1.4 (37f45d7) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5280   +/-   ##
=========================================
  Coverage     63.37%   63.37%           
  Complexity     1394     1394           
=========================================
  Files           195      195           
  Lines          4120     4120           
=========================================
  Hits           2611     2611           
  Misses         1509     1509           
Impacted Files Coverage Δ Complexity Δ
src/Commands/InstallCommand.php 71.42% <33.33%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f45d7...b6a2911. Read the comment docs.

@emptynick emptynick merged commit e22d212 into 1.4 May 1, 2021
@emptynick emptynick deleted the 1.4_install-windows branch August 31, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants