Fix error on relationship server side search and order while using accessor #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not try to search or order server side if an accessor is used for belongsTo relationship. Add `sortColumnList` array to pass to the view to check which columns can be server side ordered. Renamed method `findRelationshipRow` to `findSearchableRelationshipRow` for clarity
Codecov Report
@@ Coverage Diff @@
## 1.4 #5245 +/- ##
============================================
+ Coverage 63.37% 63.48% +0.11%
- Complexity 1394 1399 +5
============================================
Files 195 195
Lines 4120 4138 +18
============================================
+ Hits 2611 2627 +16
- Misses 1509 1511 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 1.4 #5245 +/- ##
============================================
+ Coverage 63.45% 63.57% +0.11%
- Complexity 1393 1398 +5
============================================
Files 195 195
Lines 4116 4134 +18
============================================
+ Hits 2612 2628 +16
- Misses 1504 1506 +2
Continue to review full report at Codecov.
|
emptynick
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to search or order server side if an accessor is used for belongsTo relationship.
Pass
sortableColumnsto the view to check which columns can be server side ordered.Rename method
findRelationshipRowtofindSearchableRelationshipRowfor clarity.