Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radio button with zero value #5223

Merged
merged 2 commits into from
May 3, 2021

Conversation

MrCrayon
Copy link
Collaborator

Removed some insanity and simplified with new null coalescing operator.

$selected_value should be in priority order:
value sent
value saved in db
default set in BREAD settings
NULL

Fixes #5221

Removed some insanity and simplified with _new_ null coalescing operator.

Fixes thedevdojo#5221
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #5223 (35a0840) into 1.4 (3c2d314) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5223   +/-   ##
=========================================
  Coverage     63.37%   63.37%           
  Complexity     1394     1394           
=========================================
  Files           195      195           
  Lines          4120     4120           
=========================================
  Hits           2611     2611           
  Misses         1509     1509           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2d314...35a0840. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #5223 (1b71233) into 1.4 (5e05e4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5223   +/-   ##
=========================================
  Coverage     63.45%   63.45%           
  Complexity     1393     1393           
=========================================
  Files           195      195           
  Lines          4116     4116           
=========================================
  Hits           2612     2612           
  Misses         1504     1504           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e05e4a...1b71233. Read the comment docs.

@emptynick emptynick merged commit 16a0c25 into thedevdojo:1.4 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio button from bread doesn't show the selected value if "0" (zero) is selected
3 participants