Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relationship could not be set as required #5192

Conversation

MrCrayon
Copy link
Collaborator

@MrCrayon MrCrayon commented Jan 9, 2021

Let user choose if relationship should be required.
Add required attribute in select if field is set as required.

Schermata da 2021-01-09 05-56-49

Fixes #5190

Add required attribute in select
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #5192 (e06a70c) into 1.4 (b93e322) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5192   +/-   ##
=========================================
  Coverage     63.31%   63.31%           
  Complexity     1379     1379           
=========================================
  Files           194      194           
  Lines          4075     4075           
=========================================
  Hits           2580     2580           
  Misses         1495     1495           
Impacted Files Coverage Δ Complexity Δ
src/Models/DataType.php 60.30% <100.00%> (ø) 56.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93e322...e06a70c. Read the comment docs.

@emptynick emptynick merged commit 916a4d4 into thedevdojo:1.4 Jan 28, 2021
@MrCrayon MrCrayon deleted the set-relationship-as-required-if-foreign-field-is-not-nullable branch February 11, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "None" default value on relationship select box
3 participants