-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature server side order and search for belongsto field #5185
Feature server side order and search for belongsto field #5185
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.4 #5185 +/- ##
============================================
+ Coverage 63.21% 63.58% +0.36%
- Complexity 1383 1384 +1
============================================
Files 194 194
Lines 4081 4081
============================================
+ Hits 2580 2595 +15
+ Misses 1501 1486 -15
Continue to review full report at Codecov.
|
@Stehos thanks again for checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrCrayon I checked this and both things seems to be working for me without issues. Searching sorting, too.
Sorry, I didn't see your comment. The discussion on the slack was not related to this thing. I also approved your last commit and I am not sure but I think this was causing my issues two days ago. Thank you a lot. |
This work for me
|
Using @muriloferanti's solution works well, as it fixes On top of this, I've used the following snippet to completely disable
_Fix similar to the one attempted in here @ #5312 . _ If we could get a fix for the |
Enable order and search server side for belongsto relationship fields.
For the search I am applying a global scope, that's the only things that will not require to reimplement pagination manually, for that reason I had to move search checks because globalScope needs to be added as first thing or will not work.Added a couple of tests, both using a scope and sofdelete work but we should probably add tests for those too.
Closes #2661 and closes #3595
Supersede #5120