Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #5150

Merged
merged 2 commits into from
Nov 28, 2020
Merged

PHP 8 support #5150

merged 2 commits into from
Nov 28, 2020

Conversation

emptynick
Copy link
Collaborator

This PR is WIP and will bring PHP 8 support (hopefully)

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5150 (fe5c672) into 1.4 (e8d6da8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5150   +/-   ##
=========================================
  Coverage     63.26%   63.26%           
  Complexity     1379     1379           
=========================================
  Files           194      194           
  Lines          4064     4064           
=========================================
  Hits           2571     2571           
  Misses         1493     1493           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d6da8...fe5c672. Read the comment docs.

@emptynick emptynick marked this pull request as ready for review November 28, 2020 12:31
@emptynick emptynick merged commit a94b1fe into 1.4 Nov 28, 2020
@emptynick emptynick deleted the php8-support branch November 28, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants