Hide text for buttons for small screens in read view #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide text for buttons for small screens in read view
Codecov Report
@@ Coverage Diff @@
## 1.4 #5105 +/- ##
=========================================
Coverage 63.31% 63.31%
Complexity 1379 1379
=========================================
Files 194 194
Lines 4075 4075
=========================================
Hits 2580 2580
Misses 1495 1495 Continue to review full report at Codecov.
|
emptynick
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide text for buttons for small screens in read view
To be more consistent html matches the one already used for delete button:
Not sure if we should consider it as breaking change or a notice could be enough in case someone is targeting span with css.
P.S.
Buttons looks awful because edit has a border while other buttons don't have it and delete has a margin-left.