Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare visibility on all constants #5104

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Declare visibility on all constants #5104

merged 3 commits into from
Dec 29, 2020

Conversation

bu4ak
Copy link
Contributor

@bu4ak bu4ak commented Oct 5, 2020

Closes #5103

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #5104 (1702241) into 1.4 (bb07333) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #5104   +/-   ##
=========================================
  Coverage     63.26%   63.26%           
  Complexity     1379     1379           
=========================================
  Files           194      194           
  Lines          4064     4064           
=========================================
  Hits           2571     2571           
  Misses         1493     1493           
Impacted Files Coverage Δ Complexity Δ
src/Database/Schema/Identifier.php 85.71% <ø> (ø) 2.00 <0.00> (ø)
src/Database/Schema/Index.php 60.00% <ø> (ø) 14.00 <0.00> (ø)
src/Database/Types/Common/CharType.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
src/Database/Types/Common/DoubleType.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
src/Database/Types/Common/JsonType.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/Database/Types/Common/NumericType.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
src/Database/Types/Common/TextType.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/Database/Types/Common/VarCharType.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
src/Database/Types/Mysql/BinaryType.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
src/Database/Types/Mysql/BitType.php 0.00% <ø> (ø) 3.00 <0.00> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb07333...1702241. Read the comment docs.

@emptynick emptynick merged commit e9160b7 into thedevdojo:1.4 Dec 29, 2020
@bu4ak bu4ak deleted the add-visibility-to-constants branch December 29, 2020 18:18
mallardduck pushed a commit to mallardduck/voyager that referenced this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility is not declared on constants.
2 participants