-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a clickable label to multiple checkbox #4992
Conversation
…he user will click the name next to the checkbox, it will not be checked, so I added a label to it so the whole thing is clickable.
Codecov Report
@@ Coverage Diff @@
## 1.4 #4992 +/- ##
=========================================
Coverage 62.96% 62.96%
+ Complexity 1373 1372 -1
=========================================
Files 194 194
Lines 4007 4007
=========================================
Hits 2523 2523
Misses 1484 1484 Continue to review full report at Codecov.
|
@@ -13,7 +13,9 @@ | |||
@endif | |||
|
|||
<input type="checkbox" name="{{ $row->field }}[{{$key}}]" | |||
{!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" /> | |||
{{$label}} | |||
{!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you return the formatting back to inline attributes? No need to change that
{{$label}} | ||
{!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" | ||
id="{{$key}}"/> | ||
{{-- i modified the checkbox and added a label so the user can click the label and have the input checked --}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this comment.
The multiple checkbox option in the BREAD does not have a label, so if the user will click the name next to the checkbox, it will not be checked, so I added a label to it so the whole thing is clickable, it's much user-friendly.
you can add more styling to it so it will get more spacing between each checkbox.