Add a clickable label to multiple checkbox #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he user will click the name next to the checkbox, it will not be checked, so I added a label to it so the whole thing is clickable.
Codecov Report
@@ Coverage Diff @@
## 1.4 #4992 +/- ##
=========================================
Coverage 62.96% 62.96%
+ Complexity 1373 1372 -1
=========================================
Files 194 194
Lines 4007 4007
=========================================
Hits 2523 2523
Misses 1484 1484 Continue to review full report at Codecov.
|
moaazmf90
changed the title
fletch3555
previously requested changes
Jun 28, 2020
| @@ -13,7 +13,9 @@ | |||
| @endif | |||
|
|
|||
| <input type="checkbox" name="{{ $row->field }}[{{$key}}]" | |||
| {!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" /> | |||
| {{$label}} | |||
| {!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" | |||
There was a problem hiding this comment.
Can you return the formatting back to inline attributes? No need to change that
| {{$label}} | ||
| {!! $checked ? 'checked="checked"' : '' !!} value="{{$key}}" | ||
| id="{{$key}}"/> | ||
| {{-- i modified the checkbox and added a label so the user can click the label and have the input checked --}} |
There was a problem hiding this comment.
Please delete this comment.
emptynick
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiple checkbox option in the BREAD does not have a label, so if the user will click the name next to the checkbox, it will not be checked, so I added a label to it so the whole thing is clickable, it's much user-friendly.
you can add more styling to it so it will get more spacing between each checkbox.